Skip to content

i18n(id): update some strings#1973

Open
hyperz111 wants to merge 22 commits intoAcode-Foundation:mainfrom
hyperz111:id#2
Open

i18n(id): update some strings#1973
hyperz111 wants to merge 22 commits intoAcode-Foundation:mainfrom
hyperz111:id#2

Conversation

@hyperz111
Copy link
Contributor

  • i18n(id): update some strings
  • i18n(id): update some strings

@github-actions github-actions bot added the translations Anything related to Translations Whether a Issue or PR label Mar 23, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 23, 2026

Greptile Summary

This PR updates approximately 200 Indonesian (id-id) translation strings, adding proper Indonesian translations for LSP-related UI strings and settings category/info labels that were previously left in English.

The overall translation quality is good, but there are several issues that need to be addressed before merging:

  • Critical — broken key name (line 510): The key "earn ad-free time" was accidentally renamed to "earn ad-free lsp-error-binary-command-requiredtime", causing the app to silently fall back to the English default for the ad-free time feature.
  • Typo (line 507): "Simpak" should be "Simpan" (save).
  • Typo (line 531): "bahas la" should be "bahasa" (language) — word split by an errant space.
  • Typo (line 646): "umpam balik" should be "umpan balik" (feedback).
  • Typo (line 670): "inisiai" should be "inisiasi" (initialization).
  • Style (line 658): Missing trailing period on settings-info-editor-live-autocomplete.

Confidence Score: 2/5

  • Not safe to merge as-is — the corrupted key name will silently break the ad-free time feature for all Indonesian-locale users.
  • A P0 key-name corruption means the ad-free feature loses its translated label entirely. The fix is a one-line change, but it must be made before this lands in production. Additionally there are four distinct typos in the translation values that would degrade the user-facing string quality.
  • src/lang/id-id.json — specifically line 510 (broken key) and lines 507, 531, 646, 670 (typos).

Important Files Changed

Filename Overview
src/lang/id-id.json Indonesian translation update for ~200 strings (lines 503–704). Contains one critical broken key name ("earn ad-free lsp-error-binary-command-requiredtime" instead of "earn ad-free time") that will silently break the ad-free feature, plus four typos in translation values ("Simpak", "bahas la", "umpam balik", "inisiai") and one missing trailing period.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[App renders UI string] --> B{Look up key in id-id.json}
    B -->|Key found| C[Display Indonesian translation]
    B -->|Key NOT found| D[Fall back to English default]
    D --> E[⚠️ 'earn ad-free time' key is broken\nin this PR — falls back to English]
    C --> F[✅ Other ~199 keys translated correctly]
Loading

Reviews (1): Last reviewed commit: "i18n(id): update some strings" | Re-trigger Greptile

"save file before home shortcut": "Simpak berkas sebelum menambahkannya ke layar beranda.",
"terminal_required_message_for_lsp": "Terminal tidak terpasang. Mohon pasang Terminal terlebih dahulu untuk menggunakan server LSP.",
"shift click selection": "Pemilihan Shift + tekan/klik",
"earn ad-free lsp-error-binary-command-requiredtime": "Ambil waktu bebas iklan",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Corrupted i18n key name will break ad-free feature

The JSON key was accidentally changed from "earn ad-free time" to "earn ad-free lsp-error-binary-command-requiredtime". It appears part of a neighbouring key name (lsp-error-binary-command-required) was unintentionally spliced into this key during editing.

Only the value (the right-hand side) should be translated — the key must remain identical to what the application source code looks up. Any code referencing "earn ad-free time" will now fall back to the English default (or produce no output) because this key no longer exists in the file.

Suggested change
"earn ad-free lsp-error-binary-command-requiredtime": "Ambil waktu bebas iklan",
"earn ad-free time": "Ambil waktu bebas iklan",

"shortcut request sent": "Permintaan pintasan dibuka. Tekan Tambah untuk menyelesaikan.",
"add to home screen": "Tambah ke layar beranda",
"pin shortcuts not supported": "Pintasan layar beranda tidak didukung di perangkat ini.",
"save file before home shortcut": "Simpak berkas sebelum menambahkannya ke layar beranda.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Typo: "Simpak" → "Simpan"

Simpak is not a standard Indonesian word. The correct verb for "save" in Indonesian is Simpan.

Suggested change
"save file before home shortcut": "Simpak berkas sebelum menambahkannya ke layar beranda.",
"save file before home shortcut": "Simpan berkas sebelum menambahkannya ke layar beranda.",

"lsp-error-add-server-failed": "Gagal menambahkan server",
"lsp-error-args-must-be-array": "Argumen harus berupa sebuah senarai JSON",
"lsp-error-binary-command-required": "Perintah binari diperlukan",
"lsp-error-language-id-required": "Setidaknya satu ID bahas la diperlukan",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Typo: "bahas la" → "bahasa"

"ID bahas la diperlukan" has an erroneous space splitting the word bahasa (language) into bahas la.

Suggested change
"lsp-error-language-id-required": "Setidaknya satu ID bahas la diperlukan",
"lsp-error-language-id-required": "Setidaknya satu ID bahasa diperlukan",

"settings-info-app-side-buttons": "Tampilkan tombol aksi ekstra di samping editor.",
"settings-info-app-sponsor-sidebar": "Tampilkan entri sponsor di bar samping.",
"settings-info-app-touch-move-threshold": "Pergerakan minimum sebelum penyeretan sentuh terdeteksi.",
"settings-info-app-vibrate-on-tap": "Aktifkan umpam balik getar untuk tekan dan kendali.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Typo: "umpam balik" → "umpan balik"

umpam balik is not a valid Indonesian phrase. The correct term for "feedback" is umpan balik (missing n).

Suggested change
"settings-info-app-vibrate-on-tap": "Aktifkan umpam balik getar untuk tekan dan kendali.",
"settings-info-app-vibrate-on-tap": "Aktifkan umpan balik getar untuk tekan dan kendali.",

"settings-info-editor-teardrop-size": "Atur ukuran penangan kursor untuk pengeditan sentuh.",
"settings-info-editor-text-wrap": "Bungkus baris panjang di dalam editor.",
"settings-info-lsp-add-custom-server": "Daftarkan server bahasa kostum dengan perintah pasang, perbarui, dan luncur.",
"settings-info-lsp-edit-init-options": "Edit opsi inisiai sebagai JSON.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Typo: "inisiai" → "inisiasi"

inisiai is missing the letter s — the correct Indonesian word is inisiasi (initialization).

Suggested change
"settings-info-lsp-edit-init-options": "Edit opsi inisiai sebagai JSON.",
"settings-info-lsp-edit-init-options": "Edit opsi inisiasi sebagai JSON.",

"settings-info-editor-line-height": "Atur jarak vertikal diantara baris.",
"settings-info-editor-line-numbers": "Tampilkan nomor baris di dalam gutter.",
"settings-info-editor-lint-gutter": "Tampilkan alat diagnostik dan penanda lint di gutter.",
"settings-info-editor-live-autocomplete": "Tampilkan saran ketika anda mengetik",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing trailing period

Every other descriptive string in this file ends with a period. This string is missing one, which creates an inconsistency in the UI.

Suggested change
"settings-info-editor-live-autocomplete": "Tampilkan saran ketika anda mengetik",
"settings-info-editor-live-autocomplete": "Tampilkan saran ketika anda mengetik.",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Anything related to Translations Whether a Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant