Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 2 | Module-Data-Groups#1069
Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 2 | Module-Data-Groups#1069mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Author
|
Hi CJ, I have just submitted my Pull Request for the Sprint 2 exercises. I really enjoyed the challenges in this sprint, especially learning how to refactor functions and using tools like All tests are passing, and I made sure my comments clearly explain the logic behind the code. I am looking forward to your review and any feedback or suggestions you might have. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Reviewers / CodeYourFuture Team,
I have completed all mandatory and stretch exercises for Sprint 2. I made sure to thoroughly test my code, handle edge cases, and apply refactoring best practices.
Here is a summary of the progress:
address.js,author.js, andrecipe.jsby utilizing proper object iteration (Object.entries,Object.values) and correct property access.contains,lookup, andtally. I also fixed thequerystringfunction usingindexOf("=")andslice()to correctly handle multiple equal signs securely.invert.jsusing bracket notation to dynamically assign keys and values. All analytical questions (a-e) have been clearly answered in the comments.count-words.js: Implemented Regex to remove punctuation, handled case insensitivity, and sorted the final results by frequency.mode.js: Successfully refactored the function into two smaller, single-responsibility functions (countFrequenciesandfindHighestFrequency) utilizing theMapobject.till.js: Fixed theNaNbug by usingparseInt()to accurately extract numerical values from strings.Testing: Verified that all tests across all folders pass successfully using
npx jestand manualnodetesting.Personal Note for the Team:
Working with
Map,Object.entries(), and data type parsing in this sprint greatly improved my understanding of how to safely manipulate complex objects in JavaScript. I have also ensured all my comments explain the "why" behind the code to be fully screen-reader compatible. I look forward to your feedback!Best regards,
Mahmoud Shaabo