Glasgow | JAN ITP-2026|Tuan Nguyen | Sprint 1 | Programming-fundamentals by Jacknguyen4438 · Pull Request #1140 · CodeYourFuture/Module-Structuring-and-Testing-Data

Jacknguyen4438 · 2026-03-03T01:32:46Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have finish all 3 section from sprint 1:

Key-exercises.
Mandatory-errors.
Mandatory-interpret
If there is some exercise or course from sprint 1 I need to fix and improve please let me know.

Questions

Yes I see that in sprint 3 I need to make multiple PR request. Could I do that in the same branch for sprint 3 or I need to make like sub branch from sprint 3 branch in order to submit?

…y for the PR

cjyuan

I noticed some minor inconsistency formatting in the code/comments.

Have you installed prettier VSCode extension and enabled formatting on save/paste on VSCode as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md

Sprint-1/1-key-exercises/1-count.js

Sprint-1/1-key-exercises/2-initials.js

Sprint-1/1-key-exercises/3-paths.js

Sprint-1/1-key-exercises/4-random.js

Sprint-1/2-mandatory-errors/1.js

Sprint-1/2-mandatory-errors/3.js

Sprint-1/2-mandatory-errors/4.js

Sprint-1/3-mandatory-interpret/1-percentage-change.js

Sprint-1/3-mandatory-interpret/2-time-format.js

cjyuan · 2026-03-05T18:55:10Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

 const pence = paddedPenceNumberString
  .substring(paddedPenceNumberString.length - 2)
  .padEnd(2, "0");


Optional challenge question (no change required):

Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script? Why?

Jacknguyen4438 · 2026-03-10T01:06:13Z

@cjyuan Hello Yuan, thank you for the review you give me I am very grateful for the insight. I can see that there are many section I need to fix, so I would like to notify you that I have read the PR review and in the progress of fixing it. I understand that you are very busy with other PR as well and I was radio silent do to I am doing sprint 3 of module 2 at the moment. When I finish fixing and ready to be review I will mention you again thank you.

ykamal · 2026-03-12T16:28:51Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js


 carPrice = Number(carPrice.replaceAll(",", ""));
-priceAfterOneYear = Number(priceAfterOneYear.replaceAll("," ""));
+priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));


This is fine, but the link below is worth looking into. it's an abstraction over this and will probably serve you better in the long run:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt

@ykamal Thank you for the link. I have read through and see that it indeed more organise then the current method I write in the code. I will try to used in my course work next time.

Jacknguyen4438 · 2026-03-22T01:49:06Z

Hello @cjyuan I have make change base on the review suggestion from both you and ykamal. I am ready for another PR review and please if I need to make further change please let me know

cjyuan · 2026-03-22T09:50:47Z

Sprint-1/1-key-exercises/3-paths.js

+/*
+const slashIndex = filePath.indexOf("/");
+const dir =filePath.slice(slashIndex + 0, 45) ;
+const ext =filePath.slice(slashIndex + 49, 53);


Why keep this code? Best practice is to remove unused code to keep our code clean. And doing so also helps make code review easier.

Thank you for point this out, I forgot to remove it when I fix the code. When you check again this line of code will be remove

cjyuan · 2026-03-22T09:56:23Z

Sprint-1/1-key-exercises/3-paths.js

+let dirDirectory = filePath.slice(filePath.indexOf("/"),filePath.lastIndexOf("/"));
+let extDirectory = filePath.slice(filePath.lastIndexOf("/"));
+console.log(`The dir part of the file is ${dirDirectory}.`);
+console.log(`The ext part of the file is ${extDirectory}.`);


Suppose filePath is "/tmp/file.txt". Based on your understanding of the anatomy of a file path on lines 3-8, can you tell which part of the file path is considered the dir part and which part of it is considered the ext part?

When you run your code, does your code output the values you expected?

Thank you for the feed back I have check again and see some part that I write incorrect. My answer will be include when I finish and commit sync to github.

Sprint-1/2-mandatory-errors/4.js

cjyuan · 2026-03-23T03:36:57Z

Sprint-1/1-key-exercises/3-paths.js

+let dirDirectory = filePath.slice(filePath.indexOf("/"),filePath.lastIndexOf("."));
+let extDirectory = filePath.slice(filePath.lastIndexOf("."));
+let baseDirectory = filePath.slice(filePath.lastIndexOf("/"));


The value of the "dir" part is still not correct.

Note:

"dir" already stands for "directory"

"ext" stands for extension (or file extension); it is not a directory

"base" is also not necessary a directory

The value of "base' has already been extracted on line 14. The value you extracted on line 23 is not quite correct (because your code includes the '/' character in the base).

Jacknguyen4438 added 5 commits February 27, 2026 02:23

solving some practice before moving to course work

ae2a475

Doing some error change that in section 2 of sprint 1

20fb215

This commit is for section 3 of sprint 1 brach

ba2b449

Finish movieLength course work and push it to repo

4a643cc

Finish the last exercise of the section 3 sprint course work and read…

8d780b8

…y for the PR

This comment has been minimized.

Sign in to view

Jacknguyen4438 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 3, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026

This comment has been minimized.

Sign in to view

Jacknguyen4438 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 3, 2026

cjyuan reviewed Mar 5, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2026

ykamal reviewed Mar 12, 2026

View reviewed changes

Jacknguyen4438 mentioned this pull request Mar 13, 2026

ITP January-2026/ Structuring and testing data / Tuan Ngoc Nguyen Jacknguyen4438/My-Coursework-Planner#44

Open

Jacknguyen4438 added 7 commits March 15, 2026 01:47

Fixing the first 3 work from 1-key-excercise

54de241

basic change

62e8714

Refix 1.js in second section.

041e4fc

3-paths.js fixing

1f147eb

fixing the cardNumber problem.

9fbf280

Quick change to the original cardNumber

fcb1b97

Finished the last 3 part need to change for PR review

1f8489e

Jacknguyen4438 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026

cjyuan reviewed Mar 22, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026

Jacknguyen4438 and others added 2 commits March 23, 2026 02:55

Making chang for requesting pr review again.

fd5b31a

Merge branch 'main' into programming-funamental-sprint-1

9b4e1ce

cjyuan reviewed Mar 23, 2026

View reviewed changes

Uh oh!

Conversation

Jacknguyen4438 commented Mar 3, 2026

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Jacknguyen4438 commented Mar 10, 2026

Uh oh!

ykamal Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jacknguyen4438 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Jacknguyen4438 commented Mar 22, 2026

Uh oh!

cjyuan Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Jacknguyen4438 Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jacknguyen4438 Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ykamal Mar 12, 2026 •

edited

Loading

cjyuan Mar 22, 2026 •

edited

Loading