refactor: add error logging for process group kill failures#18596
Open
jingla2026 wants to merge 4 commits intoanomalyco:devfrom
Open
refactor: add error logging for process group kill failures#18596jingla2026 wants to merge 4 commits intoanomalyco:devfrom
jingla2026 wants to merge 4 commits intoanomalyco:devfrom
Conversation
Adds error logging in the catch block when attempting to kill a process group. This helps with debugging process termination issues.
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
jingla2026
changed the title
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Improves error handling in process termination.
Type of change
What does this PR do?
Adds error logging when attempting to kill a process group fails. The error was previously ignored (caught as
_e), making it difficult to debug process termination issues.How did you verify your code works?
Checklist