fix(utils): recursively copy tuples in deepcopy_minimal to prevent in-place mutation#1270
Open
tao-to-python wants to merge 1 commit intoanthropics:mainfrom
Open
fix(utils): recursively copy tuples in deepcopy_minimal to prevent in-place mutation#1270tao-to-python wants to merge 1 commit intoanthropics:mainfrom
tao-to-python wants to merge 1 commit intoanthropics:mainfrom
Conversation
…-place mutation deepcopy_minimal only handled dicts and lists, so tuples containing mutable objects (like dicts) were returned as-is. When files.beta.upload receives a FileTypes tuple like (filename, content, mime, headers_dict), the headers dict inside the tuple could be mutated in place and returned to the caller changed. Add tuple support so mutable elements inside tuples are properly copied. Fixes anthropics#1202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes in-place mutation of user-provided data when using
files.beta.upload, as reported in #1202.Problem
deepcopy_minimalonly recursively copiesdictandlist. When aFileTypestuple like(filename, content, mime_type, headers_dict)is passed, the tuple is returned as-is. Theheaders_dict(4th element) shares the same reference, so internal SDK mutations propagate back to the caller.Solution
Add
tuplehandling todeepcopy_minimal:This ensures mutable objects inside tuples (like the headers dict) are properly copied.
Changes
src/anthropic/_utils/_utils.pydeepcopy_minimalFixes #1202