<compare>: fix constructibility of ordering types#5911
Open
vmichal wants to merge 13 commits intomicrosoft:mainfrom
Open
<compare>: fix constructibility of ordering types#5911vmichal wants to merge 13 commits intomicrosoft:mainfrom
<compare>: fix constructibility of ordering types#5911vmichal wants to merge 13 commits intomicrosoft:mainfrom
Conversation
…onstructible from int. Prevent structured bindings.
StephanTLavavej
changed the title
<compare>: fix constructibility of ordering types, prevent structured bindings
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
changed the title
<compare>: fix constructibility of ordering types, prevent structured bindings<compare>: fix constructibility of ordering types
Record the bug title. `typename` => `class` for consistency. Drop todo about structured bindings.
Comment why the deleted ctors need to be constexpr. We conventionally avoid abbreviated function templates. We don't need a secret tag; `template <int>` suffices because it can't be deduced.
StephanTLavavej
approved these changes
Mar 20, 2026
Member
|
Thanks! 😻 I pushed the following changes:
This appears to be ABI-safe: https://godbolt.org/z/MhqeoerKK |
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2026
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touches
std::strong_ordering,std::weak_ordering,std::partial_ordering.Fixes #5689.