Open
Conversation
Collaborator
|
Review requested:
|
jasnell
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Perfetto SDK as a dependency of Node.js. Notably, this does not add the full Perfetto library as the dependency. The full perfetto library contains Perfetto data pipeline processing support. The Perfetto SDK only supports emitting tracing data.
This is part of the nodejs/diagnostics#654 discussion that V8 moves away from the legacy tracing library.
Key points:
This PR only adds the Perfetto SDK. The actual adoption is blocked on #61898 with patches in https://issues.chromium.org/issues/457135433.
Commit efdce9a can be fully reproduced with
tools/dep_updaters/update-perfetto.sh.Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433