fixing issue where FastAPI would not allow new paths to be added#3668
Open
BSd3v wants to merge 1 commit intoplotly:v4.1from
Open
fixing issue where FastAPI would not allow new paths to be added#3668BSd3v wants to merge 1 commit intoplotly:v4.1from
BSd3v wants to merge 1 commit intoplotly:v4.1from
Conversation
BSd3v
requested review from
T4rk1n,
camdecoster,
emilykl and
ndrezn
as code owners
T4rk1n
reviewed
Mar 20, 2026
Comment on lines
+191
to
+192
| print("Error during catch-all setup:") | ||
| print(traceback.format_exc()) |
Contributor
There was a problem hiding this comment.
traceback.print_exc() should be enough.
|
|
||
| def _setup_catchall(self): | ||
| try: | ||
| print("Setting up catch-all route for unmatched paths") |
Contributor
There was a problem hiding this comment.
Remove print or replace with a logger.debug call.
| methods: list[str] | None = None, | ||
| include_in_schema: bool = False, | ||
| ): | ||
| print(f"Adding URL rule: {rule} -> {view_func} (endpoint: {endpoint}, methods: {methods})") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3667
This uses the lifespan to load the catchall when the server starts, allowing all other urls to be added properly.