Skip to content

Ensure that serialized arrays have 0 offset#7103

Open
robert3005 wants to merge 3 commits intodevelopfrom
rk/offsetzero
Open

Ensure that serialized arrays have 0 offset#7103
robert3005 wants to merge 3 commits intodevelopfrom
rk/offsetzero

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Mar 20, 2026

While the writer will always make sure this is the case users of the api can
serialise arrays with arbitrary offsets which then fail to deserialise

fix #7094

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Mar 20, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
Copy link
Contributor Author

We rely on being able to ser/de RunEnd metadata for arrow conversion without depending on the RunEndArray directly.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 21, 2026

Merging this PR will degrade performance by 15.51%

❌ 2 regressed benchmarks
✅ 1014 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[1024] 477.2 ns 535.6 ns -10.89%
Simulation bitwise_not_vortex_buffer_mut[128] 317.8 ns 376.1 ns -15.51%

Comparing rk/offsetzero (60daa39) with develop (18359a8)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SparseArray slices can serialize with non-zero patch offsets, but SparseVTable::build asserts offset == 0

1 participant